Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slightly optimizes client performance #4610

Merged
merged 1 commit into from
Oct 9, 2023

Conversation

Zonespace27
Copy link
Contributor

@Zonespace27 Zonespace27 commented Oct 8, 2023

About the pull request

Ports DaedalusDock/daedalusdock#638, credit to Kapu for the PR

Explain why it's good for the game

By having the icon be null (instead of icon_state being ""), BYOND processes one less appearance (that of the invisible area) per turf. That being said, appearance-to-icon is cached, but this is free performance.

Testing Photographs and Procedure

Screenshots & Videos

It doesn't fuck with weather or anything

@Zonespace27 Zonespace27 added the Code Improvement Make the code longer label Oct 8, 2023
Copy link
Member

@fira fira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thought that might break weather effects but they seem to work just same

@harryob harryob added this pull request to the merge queue Oct 9, 2023
Merged via the queue into cmss13-devs:master with commit e03c820 Oct 9, 2023
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Improvement Make the code longer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants