-
Notifications
You must be signed in to change notification settings - Fork 565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
marine helmets no longer spawn with squad optics. #4618
marine helmets no longer spawn with squad optics. #4618
Conversation
If you’re doing something like this you should make the squad optic available to add to your helmet if you like how it looks. The marines in the movie had the optics. You could just stick the item in the surplus vendor or flavor menu. It would be even better if you could toggle which huds cycle on the button so you could disable the ones you don’t like. |
sounds good, i'll add them to surplus |
built_in_visors = list(new /obj/item/device/helmet_visor, new /obj/item/device/helmet_visor/welding_visor) | ||
built_in_visors = list(new /obj/item/device/helmet_visor/welding_visor) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
must have accidentally copied that instead of removing helmet visor, oops.
var/datum/action/item_action/cycle_helmet_huds/cycle_action = locate() in actions | ||
cycle_action.set_default_overlay() | ||
if(!length(built_in_visors)) | ||
cycle_action.remove_from(user) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
?
code/game/machinery/vending/vendor_types/squad_prep/squad_prep.dm
Outdated
Show resolved
Hide resolved
Co-authored-by: Zonespace <[email protected]>
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
About the pull request
marine helmets no longer spawn with squad optics.
can still be found in surplus uniform vendors.
Explain why it's good for the game
currently squad optics serve no purpose, their only function (showing roles of allies) is already fulfilled by having your HEADSET on. I don't know of any situations where a marine would discard their headset and rely solely on their optics to save them half a second of seeing a medic's helmet to know that they are, indeed, a medic.
removing them saves me from needing to press extra buttons every time i want to swap from NVGs to medhud as an IO.
Testing Photographs and Procedure
Screenshots & Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>
tags.Changelog
🆑 Private Tristan
del: marine helmets no longer spawn with squad optics. they have been moved to surplus uniform vendors.
/:cl: