Photo Code Refactoring #4636
Merged
Photo Code Refactoring #4636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harryob
requested changes
Oct 11, 2023
Co-authored-by: harryob <[email protected]>
This comment was marked as resolved.
This comment was marked as resolved.
Drulikar
added
the
Testmerge Candidate
fira
requested changes
Oct 11, 2023
There was a problem hiding this comment.
it's all performance and games to add sleeps in the middle of code but unfortunately it also has consequences in terms of integrity and garbage collection...
i think everything else is safe sleep wise. turfs in particular we can shortcut a lot of assumptions in regard to deletions. movable atoms are bit of an issue due to deletion and movement
fira
approved these changes
Oct 12, 2023
harryob
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
This PR is a partial revival of #4584 in addition to just a general refactor of the code it was affecting. Now after every blend or getFlatIcon call there is a CHECK_TICK. Various loops use the
as anythingusage as possible to help with type checking. Additionally, the descriptions for mobs is a little more fluid, and now there is actually a description for a photo with no mobs in it.Explain why it's good for the game
This should hopefully mitigate issues where photos cause the server to stutter, but hard to know for sure without testing on live. Also the description was annoyingly rigid.
Testing Photographs and Procedure
Screenshots & Videos
(There was an additional space in this photo's description that was since removed)
Changelog
🆑 Drathek
refactor: Refactored camera code to be less blocking, use typechecks less often, and provide somewhat more fluid descriptions to photos.
/:cl: