trijent shuttle now generic #4639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Mapping
BeagleGaming1
requested changes
Oct 12, 2023
Co-authored-by: BeagleGaming1 <[email protected]>
|
Code changes done but I need to check a few things before undrafting |
harryob
requested changes
Oct 20, 2023
Co-authored-by: harryob <[email protected]>
Co-authored-by: harryob <[email protected]>
Co-authored-by: harryob <[email protected]>
Co-authored-by: harryob <[email protected]>
mullenpaul
added
the
Testmerge Candidate
fira
approved these changes
Oct 23, 2023
|
This is working on TM |
harryob
approved these changes
Oct 30, 2023
Merged
via the queue into
cmss13-devs:master
with commit Oct 30, 2023
bb09fa3
26 of 27 checks passed
cm13-github
added a commit
that referenced
this pull request
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
I have made the Trijent shuttle generic, allowing this to be reused on other mapping projects. We can also have multiple elevators in the same mission.
Trijent dam also now has two elevators.
Explain why it's good for the game
Other maps will be able to incorporate the Trijent elevator shuttle.
Testing Photographs and Procedure
Screenshots & Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>tags.Changelog
🆑
refactor: reworked trijent elevators to be reusable on new maps
maptweak: Trijent map now has two elevators, lz1 to engineering and lz2 to omega
/:cl: