Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ASO new icon #4651

Closed
wants to merge 2 commits into from
Closed

ASO new icon #4651

wants to merge 2 commits into from

Conversation

Kitsunemitsu
Copy link
Contributor

@Kitsunemitsu Kitsunemitsu commented Oct 12, 2023

About the pull request

Replaces the small steel star with a brighter, larger star.

Explain why it's good for the game

The old steel star was too hard to see on the black background.
This cleans it up to be brighter, and larger.

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
imageadd: added new ASO icon sprite.
/:cl:

@github-actions github-actions bot added the Sprites Remove the soul from the game. label Oct 12, 2023
@c4xmaniac2
Copy link
Contributor

Could you add a screenshot?

@Kitsunemitsu
Copy link
Contributor Author

Of course! Let me nab one in game

@Kitsunemitsu
Copy link
Contributor Author

okay, I cannot grab one in game, here's a screencap.
image

@BeagleGaming1
Copy link
Contributor

Couldn't this new one be seen as too similar to the "general" hudsquad?
image

@Kitsunemitsu
Copy link
Contributor Author

That is a great point, but I don't really think that the old one was good at all; and too hard to see.
Would a blue border around the white admiral star be an acceptable change?

@Kitsunemitsu
Copy link
Contributor Author

image

Here's an example

@c4xmaniac2
Copy link
Contributor

super similar to the CO star

@Kitsunemitsu
Copy link
Contributor Author

It absolutely is not.
Top to bottom, left to right.

image

New Proposed Admiral Star,
Old Admiral Star
CO Star
New ASO Star
Old ASO Star

The main problem with the old ASO star is that it's really hard to see during gameplay and looks like a mass of pixels until you squint.

@github-actions
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Oct 21, 2023
@realforest2001 realforest2001 removed the Stale beg a maintainer to review your PR label Oct 21, 2023
@github-actions
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Oct 29, 2023
@nauticall
Copy link
Contributor

I think having a different logo than the star altogether for the ASO would be good. Maybe a 🚫 symbol in gold similar to the FTL?

@Kitsunemitsu
Copy link
Contributor Author

I don't really like the FTL logo that much, but I absolutely can give it a whole different logo.

@github-actions github-actions bot removed the Stale beg a maintainer to review your PR label Nov 4, 2023
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Nov 12, 2023
@github-actions github-actions bot closed this Nov 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Sprites Remove the soul from the game. Stale beg a maintainer to review your PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants