Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reduces timer on joining ert after death to 30 seconds #4652

Merged
merged 2 commits into from
Oct 20, 2023
Merged

reduces timer on joining ert after death to 30 seconds #4652

merged 2 commits into from
Oct 20, 2023

Conversation

CapCamIII
Copy link
Contributor

@CapCamIII CapCamIII commented Oct 12, 2023 •
edited by Zonespace27
Loading

About the pull request

reduces timer

Explain why it's good for the game

Having to wait a full minute to join an ERT is annoying, it was better b4 when timer from ERT was a minute as well, but 30 second ERT means if u die just b4 ERT goes you cant join regardless.

if ppl are ghosting bc they want ert then they are stupid.

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
balance: Timer on attempting to join ERT after death is now 30 seconds down from 1 minute
/:cl:

@github-actions github-actions bot added the Balance You need to be a professional veteran game maintainer to comprehend what is being done here. label Oct 12, 2023
harryob
harryob approved these changes Oct 19, 2023
View reviewed changes
Copy link
Member

@harryob harryob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should probably make a snitch log at some point for jannies if someone ghosts when there's nothing wrong with them

Zonespace27
Zonespace27 requested changes Oct 19, 2023
View reviewed changes
Copy link
Contributor

@Zonespace27 Zonespace27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Must be at least 30 seconds.

@Zonespace27 Zonespace27 marked this pull request as draft October 19, 2023 22:29
@CapCamIII CapCamIII marked this pull request as ready for review October 20, 2023 18:18
@Zonespace27 Zonespace27 changed the title reduces timer on joining ert after death to 15 seconds reduces timer on joining ert after death to 30 seconds Oct 20, 2023
@Zonespace27 Zonespace27 added the Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. label Oct 20, 2023
@Zonespace27 Zonespace27 added this pull request to the merge queue Oct 20, 2023
Merged via the queue into cmss13-devs:master with commit e4c3900 Oct 20, 2023
26 checks passed
cm13-github added a commit that referenced this pull request Oct 20, 2023
@cm13-github
Automatic changelog for PR #4652 [ci skip]
c7283e8
@CapCamIII CapCamIII deleted the ert-timer branch October 20, 2023 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harryob harryob harryob approved these changes

@Zonespace27 Zonespace27 Awaiting requested review from Zonespace27

Assignees
No one assigned
Labels
Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. Balance You need to be a professional veteran game maintainer to comprehend what is being done here.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CapCamIII @Zonespace27 @harryob