Adds Synthetic Manufacturers #4685
Conversation
|
Requested changes made. |
| @@ -1611,6 +1614,11 @@ var/const/MAX_SAVE_SLOTS = 10 | |||
| if(new_relation) | |||
| nanotrasen_relation = new_relation | |||
|
|
|||
| if("synth_manufacturer") | |||
| var/synth_builder = input(user, "Choose your manufacturer.") as null|anything in list("Weyland-Yutani", "Borgia Industries", "Hyperdyne Systems", "Lasalle Bionational", "Seegson", "MedTech", "Grant Corporation", "AlphaTech Hardware", "Independent Manufacturer") | |||
| @@ -242,6 +243,7 @@ | |||
| adaptive_zoom = sanitize_integer(adaptive_zoom, 0, 2, 0) | |||
| tooltips = sanitize_integer(tooltips, FALSE, TRUE, TRUE) | |||
|
|
|||
| if(isnull(synth_manufacturer)) synth_manufacturer = initial(synth_manufacturer) | |||
There was a problem hiding this comment.
this should use sanitize_inlist() with the above global list
| @@ -1611,6 +1614,11 @@ var/const/MAX_SAVE_SLOTS = 10 | |||
| if(new_relation) | |||
| nanotrasen_relation = new_relation | |||
|
|
|||
| if("synth_manufacturer") | |||
| var/synth_builder = input(user, "Choose your manufacturer.") as null|anything in list("Weyland-Yutani", "Borgia Industries", "Hyperdyne Systems", "Lasalle Bionational", "Seegson", "MedTech", "Grant Corporation", "AlphaTech Hardware", "Independent Manufacturer") | |||
There was a problem hiding this comment.
this list should be a global list or define so it can be referenced later for sanitizing
|
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
About the pull request
Allows Synthetic players to select a manufacturer for their Synthetic character.
This currently does not have any tangible in-game effect outside of allowing a Synthetic player to inform themselves of who manufactured them.
In addition to a broad suite of manufactures, all of which have some basis in Aliens lore (noted in the photos below), I added a 'independent manufacturer' for edge cases. Currently players will default to Weyland-Yutani if they don't select anything.
Explain why it's good for the game
Adds a little bit of lore and flavour to a Synthetic players character building.
Testing Photographs and Procedure
Screenshots & Videos
Changelog
🆑
add: Synthetics may now select their manufacturer. This currently has no tangible in-game effect.
/:cl: