Fixes bugs with designator usage #4693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fira
changed the title
fira
added
the
Testmerge Candidate
harryob
approved these changes
Oct 20, 2023
Merged
via the queue into
cmss13-devs:master
with commit Oct 20, 2023
9d69f3a
29 of 48 checks passed
cm13-github
added a commit
that referenced
this pull request
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
The Laser Designator is a JTACer's workhorse and it's CLUNKY AS HELL.
This fixes two main bugs:
The
interacteeis not properly cleared when using the designator (or any zoomed item), causing it to be unset instead of set the next time you use it. This means if you look up then back down your designator, you can't laze.The interaction system wasn't made with movement in mind. It is a problem because zoom system allows movement, and designators are where the two meet. Now, they can explicitely keep interaction despite movement.
Explain why it's good for the game
QoL that should have been done 6 years ago, give or take
Because Zooming interactions are an awful mess, i'm flagging this for Testmerge where it'll inevitably break down
Testing Photographs and Procedure
I take designator, i look, i try to laze. I put them down, move, do it again. And again. Several combinations of actions.
The unzoom logic is blatantly busted and out of scope of the PR.
Changelog
🆑
fix: Fixed Rangefinders/Designators preventing you from lazing if you looked up/down them without moving.
fix: Fixed Rangefinders/Designators forcing you to look up/down again if you had moved while using them.
/:cl: