Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renames UPP survivor synth from combat to support synth #4703

Merged
merged 1 commit into from
Oct 20, 2023

Conversation

CapCamIII
Copy link
Contributor

@CapCamIII CapCamIII commented Oct 17, 2023

About the pull request

Renames UPP Trijent Nightmare synthvivor from UPP Combat Synth to UPP Support Synthetic.
It wasn't a combat synth in the first place.

Explain why it's good for the game

Its not a combat synth and this round that just ended by time of creation I saw a friendly synth get killed and cremated because its ID said combat synthetic, so its obviously causing problems; and I'm going out on a limb and going to guess these problems were not intended.

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
spellcheck: UPP Synth Survivor on the Trijent Dam nightmare is now called a Support Synthetic instead of a Combat Synthetic, as its not a combat synthetic
/:cl:

@github-actions github-actions bot added the Grammar and Formatting Fixes the codebase's tpyos and grammatical's errors label Oct 17, 2023
@Steelpoint
Copy link
Contributor

Based on my understanding of our interpretation of the UPP, they don't use support synthetics, all their synthetics (which are usually stolen) are combat synthetics.

Its just that I had to make the UPP survivor synth a non-combat synth for balance purposes.

Copy link
Contributor

@Zonespace27 Zonespace27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It shouldn't have been this way in the first place; either make it a combat synth or label it as a support synth and make it such

@Zonespace27 Zonespace27 added Fix Fix one bug, make ten more and removed Grammar and Formatting Fixes the codebase's tpyos and grammatical's errors labels Oct 20, 2023
@Zonespace27 Zonespace27 added this pull request to the merge queue Oct 20, 2023
Merged via the queue into cmss13-devs:master with commit dff3a75 Oct 20, 2023
27 checks passed
cm13-github added a commit that referenced this pull request Oct 20, 2023
@CapCamIII CapCamIII deleted the upp-synthvivor branch October 20, 2023 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Fix one bug, make ten more
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants