Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a popup when attempting to do a flyby from the ground #4709

Closed
wants to merge 2 commits into from

Conversation

TheGamerdk
Copy link
Contributor

@TheGamerdk TheGamerdk commented Oct 17, 2023

About the pull request

It’s always good to have confirmation when attempting to do an action that can kill all living marines

Explain why it's good for the game

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
qol: You’re now promoted to confirm when you attempt to do a flyby from the ground
/:cl:

@github-actions github-actions bot added the Quality of Life Make the game harder to play label Oct 17, 2023
@PhantomEpicness
Copy link
Contributor

This is a removal. QoL would be a confirmation telling the PO that they are going to land back on the ground, not removal of the feature outright.

@TheGamerdk
Copy link
Contributor Author

This is a removal. QoL would be a confirmation telling the PO that they are going to land back on the ground, not removal of the feature outright.

Updated

@TheGamerdk TheGamerdk marked this pull request as draft October 17, 2023 18:33
@TheGamerdk TheGamerdk changed the title Makes it impossible to launch a flyby while the dropship is on the ground. Adds a popup when attempting to do a flyby from the ground Oct 17, 2023
@TheGamerdk TheGamerdk marked this pull request as ready for review October 17, 2023 18:54
@cm13-github cm13-github added the Merge Conflict PR can't be merged because it touched too much code label Oct 17, 2023
@cm13-github
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@Drulikar Drulikar marked this pull request as draft October 21, 2023 02:32
@github-actions
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Oct 29, 2023
@github-actions github-actions bot closed this Nov 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Merge Conflict PR can't be merged because it touched too much code Quality of Life Make the game harder to play Stale beg a maintainer to review your PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants