Fixes Langchat X offsets for Megaphone/Xenos #4725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harryob
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
Langchat has incorrect calc for X offsets, which results in goofy speech through megaphone and some big xenos text being off-center
This brings them in line accounting for atom dimension using
get_pixel_position_xExplain why it's good for the game
Looks less goofy especially for megaphone
Testing Photographs and Procedure
Tested megaphone and queen result in centered text. Also tested adjusting pixel_x on source atom and that it was still the case.
I'd post an image of the problem but all i have is current round's
Changelog
🆑
fix: Xeno and Megaphone abovehead chat speech should now properly be centered horizontally.
/:cl: