Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4 New Haircuts #4728

Merged
merged 5 commits into from
Oct 25, 2023
Merged

4 New Haircuts #4728

merged 5 commits into from
Oct 25, 2023

Conversation

XDinka
Copy link
Contributor

@XDinka XDinka commented Oct 19, 2023

About the pull request

Some new haicuts

Looking at the current sheet it occurred to me to add a few current popular hairstyles that have passed the community evaluation.

It's a bit hard for me to write text and descriptions due to my poor language skills, but I'll try to describe as much as I can.

Explain why it's good for the game

First of all, playing on the server we try to associate ourselves with the character, try to be in his skin. His appearance plays an important role. A couple of beautiful hairstyles will please the eye of players and add a little more variety

Photographs

Screenshots & Videos

Gentle Ponytail

image

hair_gentleponytail

Edgar haircut

image

hair_edgar

Emo Bun

image

hair_emobun

Taper haircut

image

hair_taper

Changelog

🆑 XDinka
add: Added four new haircuts: gentle ponytail, edgar haircut, emo bun, taper haircut.
/:cl:

@github-actions github-actions bot added Sprites Remove the soul from the game. Code Improvement Make the code longer labels Oct 19, 2023
@BeagleGaming1 BeagleGaming1 added Feature Feature coder badge and removed Sprites Remove the soul from the game. labels Oct 20, 2023
@BeagleGaming1
Copy link
Contributor

"Code" is used for code improvements, improvements to code without adding new content. You don't need to use "imageadd" if you are also adding a feature, it can be assumed. This is a feature so you would be using "add" in the changelog.

@Drulikar Drulikar added Sprites Remove the soul from the game. and removed Code Improvement Make the code longer labels Oct 21, 2023
Copy link
Contributor

@Drulikar Drulikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes are fine and working in the creator. Still needs sprite approval.

@XDinka XDinka requested a review from Drulikar October 23, 2023 07:51
@Drulikar
Copy link
Contributor

I have already reviewed and approved. You need sprite review as I said.

@Drulikar Drulikar requested a review from a team October 24, 2023 00:11
@XDinka
Copy link
Contributor Author

XDinka commented Oct 25, 2023

@cm13-github/spriters pr is still need ur review.

Copy link
Contributor

@FransFeiffer FransFeiffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sprites good, LGTM

@FransFeiffer FransFeiffer added this pull request to the merge queue Oct 25, 2023
@FransFeiffer FransFeiffer added the Sprites Approved confirmed no stray pixels label Oct 25, 2023
Merged via the queue into cmss13-devs:master with commit dec69dd Oct 25, 2023
26 checks passed
cm13-github added a commit that referenced this pull request Oct 25, 2023
@Teragenic Teragenic mentioned this pull request Nov 17, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature coder badge Sprites Approved confirmed no stray pixels Sprites Remove the soul from the game.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants