Disables code in icon2html that causes bad icon operations #4732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bad icon operation. Tested specifically by reacting epi in a human. The icon2html will just display nothing for a mob instead of crashing.
Zonespace27
added
the
Testmerge Candidate
fira
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
This PR disables MrStonedOne's workaround in icon2html specifically for humans. Rather than throwing a bad icon operation, the resulting icon will just be blank.
Explain why it's good for the game
Situations that cause tens of thousands of runtimes in a round need to be eliminated.
Testing Photographs and Procedure
Screenshots & Videos
Changelog
🆑 Drathek
fix: Disabled code in icon2html that is causing bad icon operations
/:cl: