Fix cluster and incend OB not respecting ceiling protections #4746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
fira
approved these changes
Oct 20, 2023
harryob
approved these changes
Oct 21, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
cm13-github
added
the
Merge Conflict
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
…otection # Conflicts: # code/modules/cm_marines/orbital_cannon.dm
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
cm13-github
removed
the
Merge Conflict
fira
approved these changes
Oct 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
This PR makes it so incend and cluster OBs actually respect ceiling protections (not just pylon protections). HE already is respecting closed areas, so your fault for leaving the doors open.
Explain why it's good for the game
Dropships ceilings were changed fairly long ago to protect against OBs, but the implementation I guess was never tested thoroughly.
Testing Photographs and Procedure
Screenshots & Videos
https://youtu.be/Fc0q9p6hmeE
Changelog
🆑 Drathek
fix: Fix incend and cluster OBs not respecting ceiling OB protections.
/:cl: