Unbinds ahelp due to it being doubled up #4749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drulikar
approved these changes
Oct 21, 2023
realforest2001
approved these changes
Oct 21, 2023
harryob
approved these changes
Oct 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
This removes the default bind for AdminHelp because SSinput already has an hardcoded bind for it, causing it to fire twice. You're still welcome to also bind ahelp to another key. This does not affect existing users because it only changes the default preset.
Explain why it's good for the game
It's less of an issue with the new tgui ahelp box but has been a thing forever and still doubles up the chat help message.
Testing Photographs and Procedure
Reset keybinds, pressed F1, tried reloading game etc
Changelog
🆑
fix: Removed redundant double binding for F1 to AdminHelp from default keybinds. This does not affect existing users or their settings.
/:cl: