Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

turns options button into a "tab" #4754

Merged
merged 1 commit into from
Nov 2, 2023
Merged

Conversation

harryob
Copy link
Member

@harryob harryob commented Oct 21, 2023

i think it just looks nicer aesthetically. if someone disagrees particularly thats fine

🆑
ui: the options button is now part of the statbrowser tabs proper
/:cl:

@github-actions github-actions bot added the UI deletes nanoui/html label Oct 21, 2023
@Drulikar
Copy link
Contributor

This works, though TBH it would be better here or something:
image
But that will involve passing that data to the stat panel.

@github-actions
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Oct 29, 2023
@fira fira requested a review from Drulikar November 1, 2023 13:29
@Drulikar
Copy link
Contributor

Drulikar commented Nov 2, 2023

My statement above are still my thoughts, but this code as is is functional.

@Drulikar Drulikar added this pull request to the merge queue Nov 2, 2023
Merged via the queue into cmss13-devs:master with commit e5939f4 Nov 2, 2023
27 checks passed
cm13-github added a commit that referenced this pull request Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Stale beg a maintainer to review your PR UI deletes nanoui/html
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants