Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a Colony Synthetic variant, with bug fixes #4760

Merged
merged 7 commits into from
Nov 7, 2023
Merged

Adds a Colony Synthetic variant, with bug fixes #4760

merged 7 commits into from
Nov 7, 2023

Conversation

QuickLode
Copy link
Contributor

@QuickLode QuickLode commented Oct 21, 2023

About the pull request

  1. should fix fax machine problem(thx forest)
  2. gives trucker synth the frontier jumpsuit(Thwomplert)
  3. adds Freelancer Synthetic. This Synth is one that was bought off a civi market and reprogrammed, or stolen and reprogrammed, or hacked, You get the point - its going with a band of freelancers. The idea behind it is that this synth's team is dead and they are just programmed as a merc for pay - hoping to someday find their boss boss and give the money as set up. I always thought about this one for a long time and decided to put him in the civilian category, where its hard to roll and also gives you freedom to choose your allegiance. In this case I hope that a freelancer synthetic will open up unique avenue of RP and allegiance. I've only explored it once ingame, but it was very good for RP! Hopefully people can recreate this success.

was hard to make this guy look cool and I also wasn't sure on what his loadout would be. I ended up giving him random generic stuff while looking like a beat up freelancer(missing the armor especially hurt his look, since thats the largest piece of a freelancer - the curiass, but I don't want to give armor for balance reasons) and no beret because its for a SL only.

as usual, if a synth wants to change RP avenues and don different clothes for different RP, no one would know the difference

Explain why it's good for the game

  1. bug bad
  2. a beat up UA laborer that so happens to be synthetic. you wouldn't expect it because there's so many similar looking people! exactly the job of a synth - to blend in.
  3. Freelancer colony synth hopefully will open up a unique avenue of RP. If they don't want to they can always ditch it - but its on a relatively rare and uncommon roll anyways.

Testing Photographs and Procedure

[Screenshots & Videos](https://cdn.discordapp.com/attachments/490668342357786645/1166307813719556187/image.png?ex=654a03cb&is=65378ecb&hm=7108218bbaab61c78c0bedcecbfdcc07bdf9db87a3fefe9fb94b28d3430cc815&)

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
add: adds another Colony Synthetic variant, changes up some existing ones(trucker,CMB)
fix: fixes a small problem with WY-Colony Synthetic access(thx forest), adds WY subtype of Synthetics for admin building/faxes
fix: fixes problems with organic spawning ferret industries Trucker Synthetic
/:cl:

@github-actions github-actions bot added Feature Feature coder badge Fix Fix one bug, make ten more labels Oct 21, 2023
@fira
Copy link
Member

fira commented Oct 21, 2023

What's the fax machine problem? Access?

@QuickLode QuickLode changed the title Tiny Synthetic Survivor things Adds a Colony Synthetic variant, edits one, and fixes a bug Oct 21, 2023
@QuickLode QuickLode marked this pull request as draft October 24, 2023 06:38
@cm13-github cm13-github added the Merge Conflict PR can't be merged because it touched too much code label Oct 24, 2023
@cm13-github
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@cm13-github
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@cm13-github cm13-github removed the Merge Conflict PR can't be merged because it touched too much code label Oct 24, 2023
@cm13-github
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@cm13-github cm13-github added the Merge Conflict PR can't be merged because it touched too much code label Oct 24, 2023
@cm13-github cm13-github removed the Merge Conflict PR can't be merged because it touched too much code label Oct 24, 2023
@cm13-github
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@QuickLode QuickLode marked this pull request as ready for review October 24, 2023 10:00
@QuickLode QuickLode changed the title Adds a Colony Synthetic variant, edits one, and fixes a bug Adds a Colony Synthetic variant, with bug fixes Oct 24, 2023
Copy link
Contributor

github-actions bot commented Nov 1, 2023

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Nov 1, 2023
@harryob harryob added this pull request to the merge queue Nov 7, 2023
Merged via the queue into cmss13-devs:master with commit 830e002 Nov 7, 2023
27 checks passed
cm13-github added a commit that referenced this pull request Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature coder badge Fix Fix one bug, make ten more Stale beg a maintainer to review your PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants