Fixed Lagnchat Xeno offsets again, final edition i swear #4771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
realforest2001
approved these changes
Oct 23, 2023
harryob
approved these changes
Oct 24, 2023
cm13-github
added a commit
that referenced
this pull request
Oct 24, 2023
Ireuldiz
referenced
this pull request
in cmapplelings/cmreboot
Oct 24, 2023
* Fixed Lagnchat Xeno offsets again, final edition i swear (#4771) # About the pull request <!-- Remove this text and explain what the purpose of your PR is. Mention if you have tested your changes. If you changed a map, make sure you used the mapmerge tool. If this is an Issue Correction, you can type "Fixes Issue #169420" to link the PR to the corresponding Issue number #169420. Remember: something that is self-evident to you might not be to others. Explain your rationale fully, even if you feel it goes without saying. --> Fixes for Xeno langchat offsets, AGAIN. My math keeps being wrong and failing under specific cases... It turns out it's a lot simpler than what i've been trying to do too. AGH! # Testing Photographs and Procedure I brought PROPER photos of PROPER testing which hopefully means that it's a PROPER fix this time ### CLF are not very good at briefings  ### Bad CLF but with megaphone  ### Queen (icon_size=64) has joined the chat  ### Queen but offset by pixel_x  # Changelog :cl: fix: Re-Re-Fixed Xeno Above Head Chat offsets, for real this time /:cl: * Automatic changelog for PR #4771 [ci skip] --------- Co-authored-by: fira <[email protected]> Co-authored-by: cm13-github <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
Fixes for Xeno langchat offsets, AGAIN. My math keeps being wrong and failing under specific cases... It turns out it's a lot simpler than what i've been trying to do too. AGH!
Testing Photographs and Procedure
I brought PROPER photos of PROPER testing which hopefully means that it's a PROPER fix this time
CLF are not very good at briefings
Bad CLF but with megaphone
Queen (icon_size=64) has joined the chat
Queen but offset by pixel_x
Changelog
🆑
fix: Re-Re-Fixed Xeno Above Head Chat offsets, for real this time
/:cl: