Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whiskey Outpost Reqs Tweaks #4803

Merged
merged 5 commits into from
Nov 4, 2023
Merged

Conversation

fira
Copy link
Member

@fira fira commented Oct 29, 2023

About the pull request

Right now reqs on WO is a pain for three major reasons:

  • Marines have less gearing option making Req Line an huge burden
  • A lot of stuff is defunct or removed such as the recycler, parcel network, and vendors not containing now basic gear nowadays
  • Because of all that there is little incentive to run Reqs beyond the attachies line, meaning it becomes a pure roaming game as assistant engineers

This attempts to address it in the following ways:

  • Fixing the recycler. It now outputs materials, and can now recycle all the crates that previously littered Reqs for metal
  • Fixing req vendors. They did not benefit from eg. attachies vendor dispensing to table like Almayers'
  • Standardize the vendors contents with Almayers' to bring useful things like binos or grenades that were missing. The ammo vendor retains the spec ammo in addition to this.
  • Readds a delivery chute, related piping, paper wrap, and destination taggers, allowing Reqs to once again fax whole crates to pillboxes
  • Tweak supply pad deliveries weights and contents to make it more interesting and hopefully not ignored. This means higher chances to get materials, and new packs such as mortar shells, while reducing highly redundant packs such as floodlights.
  • Minor Req mapping adjsutments

Additionally it adds the two missing synth vendors from the Almayer to the map.

!!! Note that this enables recycler output also for other instances of the Reyclers. I don't believe it will be a major problem but they could be issued a yield penalty if you think it might. !!!

Explain why it's good for the game

QoL and making Reqs more relevant on WO, aswell as incentive using the bunker building more

Changelog

🆑
fix: Fixed recyclers (including Whiskey Outposts') and added the possibility to recycle crates with them.
fix: Standardized "vend to table" functionality of vendors, enabling it to work for Whiskey Outpost's Reqs.
add: Whiskey Outpost vendors now contain the same items as Almayer's. WO still has spare specialist ammo on top of that.
add: Readded delivery chute, wrap and tagger to Whiskey Outpost Reqs, letting you pack and send crates and items via disposals again.
balance: Whiskey Outpost supply drops should now be more interesting and impactful.
add: Added missing Synth vendors on WO.
/:cl:

@github-actions github-actions bot added Mapping did you remember to save in tgm format? Fix Fix one bug, make ten more Feature Feature coder badge Balance You need to be a professional veteran game maintainer to comprehend what is being done here. labels Oct 29, 2023
@Zonespace27 Zonespace27 added this pull request to the merge queue Nov 4, 2023
@Zonespace27 Zonespace27 added the Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. label Nov 4, 2023
Merged via the queue into cmss13-devs:master with commit 4b794de Nov 4, 2023
26 checks passed
cm13-github added a commit that referenced this pull request Nov 4, 2023
@ghost
Copy link

ghost commented Nov 5, 2023

I think this update broke the ColMarTech Automated Munition Vendor on the Almayer where items selected will not transfer to the desk.

github-merge-queue bot pushed a commit that referenced this pull request Nov 8, 2023
# About the pull request

This PR fixes #4852 caused by #4803 simply because the vendor is not
adjacent to the table it is supposed to vend to.

# Explain why it's good for the game

It was unintentional for this to change.

# Testing Photographs and Procedure
<details>
<summary>Screenshots & Videos</summary>



https://github.com/cmss13-devs/cmss13/assets/76988376/e56607a3-7641-4c91-b585-fddeefb97098

After changing from turf to get_turf(user) per Fira:



https://github.com/cmss13-devs/cmss13/assets/76988376/a7a55df4-531c-40ea-a8a3-9b28d550f656

</details>


# Changelog
:cl: Drathek
fix: Fix the ColMarTechAutomated Munition Vendor in req not vending to
the table.
/:cl:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Feature Feature coder badge Fix Fix one bug, make ten more Mapping did you remember to save in tgm format?
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants