-
Notifications
You must be signed in to change notification settings - Fork 522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Whiskey Outpost Reqs Tweaks #4803
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Mapping
did you remember to save in tgm format?
Fix
Fix one bug, make ten more
Feature
Feature coder badge
Balance
You need to be a professional veteran game maintainer to comprehend what is being done here.
labels
Oct 29, 2023
Zonespace27
reviewed
Oct 30, 2023
Zonespace27
requested changes
Nov 1, 2023
Zonespace27
approved these changes
Nov 4, 2023
Zonespace27
added
the
Balance Approved
This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it.
label
Nov 4, 2023
cm13-github
added a commit
that referenced
this pull request
Nov 4, 2023
I think this update broke the ColMarTech Automated Munition Vendor on the Almayer where items selected will not transfer to the desk. |
This was referenced Nov 6, 2023
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 8, 2023
# About the pull request This PR fixes #4852 caused by #4803 simply because the vendor is not adjacent to the table it is supposed to vend to. # Explain why it's good for the game It was unintentional for this to change. # Testing Photographs and Procedure <details> <summary>Screenshots & Videos</summary> https://github.com/cmss13-devs/cmss13/assets/76988376/e56607a3-7641-4c91-b585-fddeefb97098 After changing from turf to get_turf(user) per Fira: https://github.com/cmss13-devs/cmss13/assets/76988376/a7a55df4-531c-40ea-a8a3-9b28d550f656 </details> # Changelog :cl: Drathek fix: Fix the ColMarTechAutomated Munition Vendor in req not vending to the table. /:cl:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Balance Approved
This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it.
Balance
You need to be a professional veteran game maintainer to comprehend what is being done here.
Feature
Feature coder badge
Fix
Fix one bug, make ten more
Mapping
did you remember to save in tgm format?
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
Right now reqs on WO is a pain for three major reasons:
This attempts to address it in the following ways:
Additionally it adds the two missing synth vendors from the Almayer to the map.
!!! Note that this enables recycler output also for other instances of the Reyclers. I don't believe it will be a major problem but they could be issued a yield penalty if you think it might. !!!
Explain why it's good for the game
QoL and making Reqs more relevant on WO, aswell as incentive using the bunker building more
Changelog
🆑
fix: Fixed recyclers (including Whiskey Outposts') and added the possibility to recycle crates with them.
fix: Standardized "vend to table" functionality of vendors, enabling it to work for Whiskey Outpost's Reqs.
add: Whiskey Outpost vendors now contain the same items as Almayer's. WO still has spare specialist ammo on top of that.
add: Readded delivery chute, wrap and tagger to Whiskey Outpost Reqs, letting you pack and send crates and items via disposals again.
balance: Whiskey Outpost supply drops should now be more interesting and impactful.
add: Added missing Synth vendors on WO.
/:cl: