Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bumps minimum compile version to 515.1609 #4808

Closed
wants to merge 11 commits into from
Closed

bumps minimum compile version to 515.1609 #4808

wants to merge 11 commits into from

Conversation

harryob
Copy link
Member

@harryob harryob commented Oct 30, 2023 •
edited
Loading

removes all the compatibility wrappers for 514, clients can still use 514 to connect

removes current alternate version test (but keeps the framework to allow them)

@harryob harryob requested a review from fira as a code owner October 30, 2023 08:21
@cm13-github cm13-github added the Merge Conflict PR can't be merged because it touched too much code label Oct 30, 2023
@cm13-github
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the Github We don't really know what else this belongs to label Oct 30, 2023
@cm13-github
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@cm13-github cm13-github removed the Merge Conflict PR can't be merged because it touched too much code label Oct 30, 2023
@harryob harryob marked this pull request as draft October 30, 2023 08:33
@github-actions GitHub Actions
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Nov 14, 2023
@github-actions github-actions bot closed this Nov 21, 2023
@harryob harryob reopened this Nov 26, 2023
@harryob harryob removed the Stale beg a maintainer to review your PR label Nov 26, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 4, 2023

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Dec 4, 2023
@github-actions github-actions bot closed this Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fira fira Awaiting requested review from fira fira is a code owner

Assignees
No one assigned
Labels
Github We don't really know what else this belongs to Stale beg a maintainer to review your PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@harryob @cm13-github @fira