Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boots Storage Refactor #4816

Closed
wants to merge 4 commits into from
Closed

Boots Storage Refactor #4816

wants to merge 4 commits into from

Conversation

fira
Copy link
Member

@fira fira commented Oct 31, 2023

About the pull request

While discussing with Beagle on the state of boots equipping shitcode, i figured it was a good spot to make a component which can hopefully be reused later down the line.

Enter simple_atom_storage whose behavior is as follow:

  • You can apply it to any /atom - tracking what's in independently of contents.
  • The storage can store a certain amount of movables.
  • You can only store movables from a list of types in it.
  • Mobs can store and retrieve from it.
  • A sound is played when interacting with it.

If anything it's here just as a practical component example and in hope of reuse. Sure it's no awesome /obj/item/storage but it works for anything that needs to store 1-# movables. Hook signals to user input and voila.

Also this stops knives from being taken out of boots in cryo, which I can't be bothered to write a handler for and was dumb anyway littering cryo list

Explain why it's good for the game

Example code, modularization

Changelog

🆑
qol: Knives won't be removed from boots in cryo storage.
/:cl:

@github-actions github-actions bot added the Quality of Life Make the game harder to play label Oct 31, 2023
@fira fira added the Code Improvement Make the code longer label Oct 31, 2023
@cm13-github cm13-github added the Merge Conflict PR can't be merged because it touched too much code label Nov 3, 2023
@cm13-github
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@cm13-github cm13-github removed the Merge Conflict PR can't be merged because it touched too much code label Nov 7, 2023
@cm13-github
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Nov 15, 2023
@github-actions github-actions bot closed this Nov 22, 2023
@fira fira mentioned this pull request Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Improvement Make the code longer Quality of Life Make the game harder to play Stale beg a maintainer to review your PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants