Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes 2 gun runtime sources #4817

Merged
merged 1 commit into from
Nov 3, 2023
Merged

Conversation

fira
Copy link
Member

@fira fira commented Nov 1, 2023

About the pull request

This fixes two issues happening on live game:

  • The XM88 does not check for successful wielding before registering signals, presumably causing overriding errors in logs.
  • M56D/M2C HMGs do not correctly reset the autofire component when the operator is removed. This causes it to try to keep firing without an operator which generates runtimes (presumably in burst fire mode). In addition this may solve other issues such as the fabled "can use HMG while dead" one, but I can't confirm it.

Explain why it's good for the game

Readable logs and less clunky interactions down the line

Changelog

🆑
fix: M56D/M2C should now properly stop firing when they stop being used.
/:cl:

@github-actions github-actions bot added the Fix Fix one bug, make ten more label Nov 1, 2023
@harryob harryob added this pull request to the merge queue Nov 3, 2023
Merged via the queue into cmss13-devs:master with commit c6a152b Nov 3, 2023
28 checks passed
cm13-github added a commit that referenced this pull request Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Fix one bug, make ten more
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants