Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spittin Facts #4821

Closed
wants to merge 1 commit into from
Closed

Conversation

Diegoflores31
Copy link
Contributor

@Diegoflores31 Diegoflores31 commented Nov 2, 2023

About the pull request

  • This PR mainly adds changes to Spitting and neuro. specially focusing on Sentinel and Queen.

Sentinel
Sentinel slowing spit now has a "combo" mechanic. that works like this:
1)Slow (4 seconds)
2)Super slow (2 seconds) - IF slowed
3)Daze ( 2 seconds)+ funny jitter effect - If super slowed
4)Stun (1.75 seconds) - if both Dazed and Superslowed or already knocked down ( stun doesnt stack) // PD : no its not infinite stun.

old behaviour
Super slow (2.5 seconds)

-No armor spit now only applies a 1.75 second stun instead of 3 seconds and doesnt stack.
-If you are hit with a no armor you will now be only stuned , not stunned and superslowed like before.
-Improved Var names and reduced code lines from slowing spit.

Queen
-Queen Acid spit will now use Praetorian Spit instead of Spitter Special spit. ( same damage but more range) to encourage queens to use this spit instead of the stun spit.
-Queen slash damage will now only vary by 1 tier instead of 2 ( thats how most xenos work currently)
-Queen Acid is now level 3

Explain why it's good for the game

Adds more gaming to sentinels so they can be more usefull as a utility-ranged Caste .

Queen gets encouraged to use the acid spit option and more consistent damage output like all other xenos.

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
add: Sentinel Slowing spit has a chain of effects (slow>superslow>daze>stun)
balance: Queen Slash damage variable is now only 1 tier instead of 2 ( 35-45 > 40-45)
balance: Queen Acid spits will no use the Praetorian version ( same damage more range)
balance: Queen now has acid tier 3
/:cl:

@github-actions github-actions bot added Feature Feature coder badge Balance You need to be a professional veteran game maintainer to comprehend what is being done here. labels Nov 2, 2023
@@ -146,12 +152,12 @@
penetration = ARMOR_PENETRATION_TIER_2
shell_speed = AMMO_SPEED_TIER_3

/datum/ammo/xeno/acid/on_shield_block(mob/M, obj/projectile/P)
burst(M,P,damage_type)
/datum/ammo/xeno/acid/on_shield_block(mob/target_mob, obj/projectile/P)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you are changing some of the var names, why not change the rest?

@Zonespace27
Copy link
Contributor

Atomize the changes (queen, sent) into different PRs

@Zonespace27 Zonespace27 closed this Nov 2, 2023
@Diegoflores31
Copy link
Contributor Author

fastest review in existance lol

@HeresKozmos
Copy link
Contributor

fastest review in existance lol

so true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Feature Feature coder badge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants