Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sentinel Neuro Combo #4822

Closed
wants to merge 3 commits into from
Closed

Conversation

Diegoflores31
Copy link
Contributor

@Diegoflores31 Diegoflores31 commented Nov 2, 2023

About the pull request

Sentinel
Sentinel slowing spit now has a "combo" mechanic. that works like this:
1)Slow (4 seconds)
2)Super slow (2 seconds) - IF slowed
3)Daze ( 2 seconds)+ funny jitter effect - If super slowed
4)Stun (1.75 seconds) - if both Dazed and Superslowed or already knocked down ( stun doesnt stack) // PD : no its not infinite stun.

old behaviour
Super slow (2.5 seconds)

-No armor spit now only applies a 1.75 second stun instead of 3 seconds and doesnt stack.
-If you are hit with a no armor you will now be only stuned , not stunned and superslowed like before.
-Improved Var names and reduced code lines from slowing spit.

Explain why it's good for the game

Adds more gaming to sentinels so they can be more usefull as a utility-ranged Caste .

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
add: Sentinel Slowing spit has a chain of effects (slow>superslow>daze>stun)
/:cl:

@github-actions github-actions bot added the Feature Feature coder badge label Nov 2, 2023
@GoldenDarkness55
Copy link
Contributor

Won't this "combo" with any other slow/daze effect leading to weird results? Should also add some kinda indicator for stacking effects like what base prae has for acid hits

@Diegoflores31
Copy link
Contributor Author

Won't this "combo" with any other slow/daze effect leading to weird results? Should also add some kinda indicator for stacking effects like what base prae has for acid hits

teamwork is fun !! i made relatively sure that you cant cheese it too easily but if you teamwork with other sentinels or use your creativity well . thats part of the game . if its found to be too OP it can be adjusted on the go

@GoldenDarkness55
Copy link
Contributor

teamwork is fun !! i made relatively sure that you cant cheese it too easily but if you teamwork with other sentinels or use your creativity well . thats part of the game . if its found to be too OP it can be adjusted on the go

It's fun but not if it's unclear, which it would be if it triggered off unrelated abilities/effects applying any of the debuffs. Also 2 sentinels spitting on same target would probably lead to permstuns, not to mention the neuro slash applies daze so you get an instant stun off it. Bruh.

@NexusStorm1
Copy link

NexusStorm1 commented Nov 2, 2023

What happens if you spit at a target already stunned/knocked down. Do they get stunned for an additional 1.75 seconds, will the combo reset and they'll get slowed, or will the spit have no effect? Also what exactly is daze? Does it also apply superslow or does it just make them shake around? Because if it's the latter then the 3rd spit becomes the weakest spit in the combo.

@Diegoflores31
Copy link
Contributor Author

teamwork is fun !! i made relatively sure that you cant cheese it too easily but if you teamwork with other sentinels or use your creativity well . thats part of the game . if its found to be too OP it can be adjusted on the go

It's fun but not if it's unclear, which it would be if it triggered off unrelated abilities/effects applying any of the debuffs. Also 2 sentinels spitting on same target would probably lead to permstuns, not to mention the neuro slash applies daze so you get an instant stun off it. Bruh.

1- if you are ALONE fighting 2 xenos at the same time ... well skill issue.
2- you have to be superslowed AND dazed . it doesnt work like that

@Diegoflores31
Copy link
Contributor Author

Diegoflores31 commented Nov 5, 2023

What happens if you spit at a target already stunned/knocked down. Do they get stunned for an additional 1.75 seconds, will the combo reset and they'll get slowed, or will the spit have no effect? Also what exactly is daze? Does it also apply superslow or does it just make them shake around? Because if it's the latter then the 3rd spit becomes the weakest spit in the combo.

no . the stun Resets to 1.75 which means trying to "stack" stuns just wont work . Daze reduces your FOV to about 3 tiles

Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Nov 13, 2023
@cm13-github cm13-github added the Merge Conflict PR can't be merged because it touched too much code label Nov 13, 2023
@cm13-github
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the Stale beg a maintainer to review your PR label Nov 14, 2023
@realforest2001 realforest2001 changed the title Spittin for u Sentinel Neuro Combo Nov 14, 2023
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Nov 22, 2023
@cm13-github cm13-github removed the Merge Conflict PR can't be merged because it touched too much code label Nov 22, 2023
@cm13-github
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@Diegoflores31
Copy link
Contributor Author

😈

Copy link
Contributor

@Zonespace27 Zonespace27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Balance-wise I'm alright with this but it seems hard to communicate to the target or xeno

no_clothes_neuro = TRUE
if((target_human.dazed && target_human.superslowed) || target_human.knocked_down || no_clothes_neuro)
target_human.apply_effect(power, WEAKEN)
target_human.visible_message(SPAN_DANGER("[target_human] collapses into the ground."))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Collapses to the ground
Also this message doesn't make sense if the target is already prone

@github-actions github-actions bot removed the Stale beg a maintainer to review your PR label Nov 23, 2023
@cm13-github cm13-github added the Merge Conflict PR can't be merged because it touched too much code label Nov 27, 2023
@cm13-github
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@fira
Copy link
Member

fira commented Dec 1, 2023

I'd suggest building on #4842 with a proper combo counter for these, it's much more powerful and robust and allows more interesting interactions than just basing off status values

@Diegoflores31
Copy link
Contributor Author

will wait for #4842 to rebuild xeno spit

Copy link
Contributor

github-actions bot commented Dec 9, 2023

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Dec 9, 2023
@github-actions github-actions bot closed this Dec 16, 2023
@Drulikar Drulikar reopened this Jan 4, 2024
@Drulikar Drulikar marked this pull request as draft January 4, 2024 01:25
@github-actions github-actions bot closed this Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature coder badge Merge Conflict PR can't be merged because it touched too much code Stale beg a maintainer to review your PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants