-
Notifications
You must be signed in to change notification settings - Fork 565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bureau du commandant - CO office #4827
Conversation
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You've made the CO's place look really boxy, we try and avoid blocky squares when possible as it looks plain bad.
Remove the CO's uniform lockdown button, there is one to the south in the hallway right outside his office.
There is a paperbin on the CO's toilet.
There is very little space in front of the CO's office chair now with only 3x tiles. It will be crowded when event's or meetings and such are done there. Shift it back to how it was and get rid of the two file cabinets there.
In the CO's bedroom there are two vendors to the north, same as with south ones place metal flooring/warning stripe usage.
The two flags on the table looks cool, nice edit.
Moving the bathroom to face the bedroom is a good change.
And finally remember, more detailing isn't always better, moderation to hinder things from being full of too much clutter!
There is a floating table in space.
Fix the above and I'll go over it again, overall good.
Conflicts have been resolved. A maintainer will review the pull request shortly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Delete the paper bin, we would need a specific sprite to ever add toilet paper..
Remember to unboxify the CO's main office as i said in the original review, add in the two corner walls again.
Shift/delete a plant maybe and move a 2x1 table down there or even put the stuff up north down there.
Good work on the CO's bedroom, but add a couple vents! and it's perfect.
Simply doesn't make sense for the things up north to be down in the entrance, its just going to make everything weird! But I will see what can I do |
Done and done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
About the pull request
An update to the CO office
Explain why it's good for the game
If people like, its good, if people don't, it is not
Testing Photographs and Procedure
Changelog
🆑
maptweak: Changes to the CO office: The bathroom now faces into the CO's bedroom, and not to his main office. Victory cabinet have been moved to the Officer's mess because of logical issues. Extra-detail to the office, including an exclusive stamp, table flags and others. The safe is now inside the CO's bedroom, and not in his office. The energy APC is now inside the CO's bedroom, and not in his office. Jones finally have a BED again, or something like that. Other minor changes to objects, such the addition of a cane, a box of glasses for serving guests, etc.
/:cl: