/tg/ Status effects part 1 - fluid status updates #4828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Code Improvement
|
Looks good TM it ✔️ |
Birdtalon
reviewed
Nov 3, 2023
cm13-github
added
the
Merge Conflict
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
cm13-github
removed
the
Merge Conflict
|
Will break down what little i can in other PRs first so they can get reviewed |
cm13-github
removed
the
Merge Conflict
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
3 tasks
3 tasks
fira
commented
Nov 23, 2023
3 tasks
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
cm13-github
added
the
Merge Conflict
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
cm13-github
removed
the
Merge Conflict
3 tasks
harryob
approved these changes
Nov 27, 2023
cm13-github
added a commit
that referenced
this pull request
Nov 27, 2023
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 19, 2023
# About the pull request <!-- Remove this text and explain what the purpose of your PR is. Mention if you have tested your changes. If you changed a map, make sure you used the mapmerge tool. If this is an Issue Correction, you can type "Fixes Issue #169420" to link the PR to the corresponding Issue number #169420. Remember: something that is self-evident to you might not be to others. Explain your rationale fully, even if you feel it goes without saying. --> Part 2 - this includes porting the actual status_effect datum, modifying it to fit our purposes by backing it with timers similarly to old system, and finally implementing KD, KO and Stun with it. This contains Part 1 PR (#4828) so if you want to take a look at it I'd advise checking the last commits or setting up a compare between both branches. # Explain why it's good for the game Predictable status timers. Current ones are bogus in their handling of "life tick correction" and will "stack" time even when they're not supposed to. Also provides a more robust backend for general effects, and integrates status effects into it. # Testing Photographs and Procedure Summary testing of buckling interactions, explosion knock times, crawling, resting. Will have to be expanded once part 1 is ready # Changelog :cl: add: Added Buckled, Handcuffed and Legcuffed screen alerts code: Ported /tg/ status effects backend, modified with timers to let effects end at appropriate time code: Stun, Knockdown and Knockout now use the new effects backend balance: Due to backend change, all KO/KD/Stuns may behave differently timing wise. This is of course subject to adjustments. balance: Endurance is now set at 8% effect duration reduction per level above 1. However it now compounds with species bonus. Feel free to adjust. balance: Knockdowns are not inherently incapacitating anymore and many sources of it have been updated to also stun to make up for it. fix: KO/KD/Stuns do not artificially and randomly ''stack'' due to incorrect timer offset calculation anymore. fix: Stuns now correctly apply Stun reduction values instead of Knockdown reductions. fix: Crawling can now be interrupted by a normal move, if you are fit enough to do so. /:cl: --------- Co-authored-by: forest2001 <[email protected]>
fira
added a commit
to fira/cmss13
that referenced
this pull request
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CM Dev figured it out 9 years ago and nobody listened and kept tacking illogical conditions
About the pull request
Builds on previous "prelude" PRs in the following steps:
update_canmovefrom existence completely as not needed anymoreBecause step 1 and 2 require updating all the gameplay logic using them, this PR modifies a lot of files.
Part 2 will move the actual status effects to /tg/ status_effects, resolving our timing problems.
Testing Photographs and Procedure
Testing Checklist!
knockoutsknockdown and sprite updatesSleeping, Waking up, Usage of items while sleeping- Can't really test this we have almost no sleep codeChangelog
🆑
code: Ported basic /tg/ Status Backend.
add: Human transform changes such as lying down, knock down, buckling, are now animated.
fix: Some statuses will now take effect immediately instead of waiting for a life tick, notably Resting.
balance: Many interaction requirements were changed to eg. fail upon stuns rather than if lying down.
/:cl: