Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better OB cannon logging #4830

Merged
merged 2 commits into from
Nov 6, 2023
Merged

Better OB cannon logging #4830

merged 2 commits into from
Nov 6, 2023

Conversation

fira
Copy link
Member

@fira fira commented Nov 3, 2023

About the pull request

This streamlines and expands OB cannon logging adding chambering log, misfuel information, and detailing both the hit target and intended aimed target. The inherent cannon inaccuracy is moved to be counted with fuel inaccuracy.

Also adds a log for locking of dropships by queen as mistakes happen every so often...

Additionally moves (JMP) for these logs to logging arguments so the whole HTML link doesnt get printed in logs

Explain why it's good for the game

Auditing

Testing Photographs and Procedure

Tested OB firing, OB JMP links, locking dropship

Changelog

🆑
admin: Added better logging for orbital bombardment.
/:cl:

@github-actions github-actions bot added the Admin Make things harder for admins label Nov 3, 2023
Copy link
Member

@harryob harryob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

glob glob glob

@harryob harryob added this pull request to the merge queue Nov 6, 2023
Merged via the queue into cmss13-devs:master with commit 08d427d Nov 6, 2023
28 checks passed
cm13-github added a commit that referenced this pull request Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Admin Make things harder for admins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants