Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small M3-VL Ballistics Vest Addition To Requisition Vendors #4836

Closed
wants to merge 3 commits into from
Closed

Small M3-VL Ballistics Vest Addition To Requisition Vendors #4836

wants to merge 3 commits into from

Conversation

KoishiVibe
Copy link

@KoishiVibe KoishiVibe commented Nov 4, 2023

Adds M3-VL vests to Requisitions armor vendors.

About the pull request

Adds 5 M3-VL vests to the Requisitions vendors at the start of the game. It's in the same format as the other entries so it should work...?

Explain why it's good for the game

Medical and other non-combatant deployed personnel may now be "in uniform" with scrubs and bodyarmor. Helps with easy identification of support personnel... for better or worse.

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
add: Added 5x M3-VL Ballistics Vests for issue to noncombat and support personnel deployed to the mission.
/:cl:

@github-actions github-actions bot added the Feature Feature coder badge label Nov 4, 2023
@Steelpoint
Copy link
Contributor

Steelpoint commented Nov 5, 2023

M3-VL is basically medium armour with light armour speed. It'd be excessively strong in the hands of regular marines. You may want to make a sub-type of this armour that uses light-armour defence values, in my opinion. If only cause internal damage.

@KoishiVibe
Copy link
Author

M3-VL is basically medium armour with light armour speed. It'd be excessively strong in the hands of regular marines. You may want to make a sub-type of this armour that uses light-armour defence values, in my opinion. If only cause internal damage.

I wonder, though. M3VL has zero bio armor so you take full damage from acid and slightly more damage from melee given the 5 less. Though I don't know if that trips any breakpoints...

But this is all fair. I mean there are some unused old images of body armor and bulletproof vests.
...what, open a PR for another M3 variant, for issue to medical personnel, as well as replacing the ones on the ship currently?

Copy link
Contributor

@Zonespace27 Zonespace27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thought about it, seems fine (except possibly HvH but 🤷)

@Zonespace27 Zonespace27 added the Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. label Nov 7, 2023
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Nov 15, 2023
@github-actions github-actions bot closed this Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. Feature Feature coder badge Stale beg a maintainer to review your PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants