Componentizes power cells #4855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cm13-github
added
the
Merge Conflict
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
cm13-github
removed
the
Merge Conflict
fira
reviewed
Nov 6, 2023
|
Tested it, looks good to me, might just need a way to modify the examine text behavior in the future to fit objects depending on where we stick it |
fira
approved these changes
Nov 7, 2023
harryob
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
Creates a new, flexible component for power cells. Eventually, anything powered will use a cell component instead of holding a ref to a
/obj/item/cellor having achargevariable.Converts NVGs over to the new system as an example, the rest will come in time.
Minor rework of how
emp_act()worksExplain why it's good for the game
Cells are one of the most obvious things to be componentized, and componentizing them allows cells to be added to new objects in a very easy manner.
Testing Photographs and Procedure
Screenshots & Videos
Works