Fix first use of USCM equipment presets #4859
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
This PR likely fixes numerous runtimes and weird issues where the first mob that uses an equipment preset will have an ID with no assignment in its name, no paygrade set, etc. This is because for some reason set_status was being used for some USCM to assign the preset's values that should have already been in the definition. Since set_status wasn't the first proc to be called in load_preset, this would result in null values such as in load_id which normally occurs before load_status.
Other values such as access and minimap icon should now be accurate (or at least the values intended as written before), but I don't know the extents of what problems those may have been for the first player of any USCM preset.
Explain why it's good for the game
The equipment presets should work with every use, not just after the first time.
Testing Photographs and Procedure
Changelog
🆑 Drathek
fix: Fix the first use of a USCM equipment preset (such as cryo marines) not properly loading rank and other values
/:cl: