Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds possibility to customize crates #4868

Merged
merged 3 commits into from
Nov 8, 2023

Conversation

fira
Copy link
Member

@fira fira commented Nov 7, 2023

About the pull request

You can now customize non-secure crates using packaging wrap, by tagging them and changing their appearance to a list of common crates. The tag works as a labeler label, and is also displayed in the overwatch supply drop alert.

Explain why it's good for the game

If anything, it's that these Squad crates are just sitting there unused. I don't know if this feature will be used much by live Reqs.

Changelog

🆑
add: You can now use package wrap to change standard crates visuals.
add: You can now label crate with package wrap, which will also be shown during overwatch supply drop alert.
mapadd: Added more packaging wrap to Requisitions.
/:cl:

@github-actions github-actions bot added Mapping did you remember to save in tgm format? Feature Feature coder badge labels Nov 7, 2023
code/datums/components/crate_tag.dm Show resolved Hide resolved
setup(name, masquarade_type)
RegisterSignal(parent, COMSIG_STRUCTURE_CRATE_SQUAD_LAUNCHED, PROC_REF(notify_squad))

/datum/component/crate_tag/InheritComponent(datum/component/C, i_am_original, name, obj/structure/closet/crate/masquarade_type)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one letter vars

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's parent signature

code/modules/cm_tech/droppod/supply.dm Show resolved Hide resolved
code/modules/cm_tech/droppod/supply.dm Outdated Show resolved Hide resolved
code/modules/recycling/sortingmachinery.dm Outdated Show resolved Hide resolved
code/modules/recycling/sortingmachinery.dm Outdated Show resolved Hide resolved
code/modules/recycling/sortingmachinery.dm Outdated Show resolved Hide resolved
code/modules/recycling/sortingmachinery.dm Outdated Show resolved Hide resolved
code/modules/recycling/sortingmachinery.dm Outdated Show resolved Hide resolved
code/modules/recycling/sortingmachinery.dm Outdated Show resolved Hide resolved
@Zonespace27 Zonespace27 added this pull request to the merge queue Nov 8, 2023
Merged via the queue into cmss13-devs:master with commit 704600a Nov 8, 2023
26 checks passed
cm13-github added a commit that referenced this pull request Nov 8, 2023
@fira fira mentioned this pull request Nov 10, 2023
github-merge-queue bot pushed a commit that referenced this pull request Nov 13, 2023
# About the pull request

<!-- Remove this text and explain what the purpose of your PR is.

Mention if you have tested your changes. If you changed a map, make sure
you used the mapmerge tool.
If this is an Issue Correction, you can type "Fixes Issue #169420" to
link the PR to the corresponding Issue number #169420.

Remember: something that is self-evident to you might not be to others.
Explain your rationale fully, even if you feel it goes without saying.
-->

I manage to screw something up with every PR it seems - see #4868 

Updated droppod constructor arguments in droppod cosmetic PR (to make it
so you have the crate falling down sky) but only did so for Overwatch
pods, not Echo's.

This causes a deleted droppod to be launched anyway and remain on the
ground. AWKWARD.


# Changelog
:cl:
fix: Fixed ghost droppods appearing when launching crates by Echo pad.
/:cl:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature coder badge Mapping did you remember to save in tgm format?
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants