Adds possibility to customize crates #4868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Mapping
Zonespace27
requested changes
Nov 7, 2023
| setup(name, masquarade_type) | ||
| RegisterSignal(parent, COMSIG_STRUCTURE_CRATE_SQUAD_LAUNCHED, PROC_REF(notify_squad)) | ||
|
|
||
| /datum/component/crate_tag/InheritComponent(datum/component/C, i_am_original, name, obj/structure/closet/crate/masquarade_type) |
realforest2001
approved these changes
Nov 7, 2023
Zonespace27
approved these changes
Nov 8, 2023
cm13-github
added a commit
that referenced
this pull request
Nov 8, 2023
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 13, 2023
# About the pull request <!-- Remove this text and explain what the purpose of your PR is. Mention if you have tested your changes. If you changed a map, make sure you used the mapmerge tool. If this is an Issue Correction, you can type "Fixes Issue #169420" to link the PR to the corresponding Issue number #169420. Remember: something that is self-evident to you might not be to others. Explain your rationale fully, even if you feel it goes without saying. --> I manage to screw something up with every PR it seems - see #4868 Updated droppod constructor arguments in droppod cosmetic PR (to make it so you have the crate falling down sky) but only did so for Overwatch pods, not Echo's. This causes a deleted droppod to be launched anyway and remain on the ground. AWKWARD. # Changelog :cl: fix: Fixed ghost droppods appearing when launching crates by Echo pad. /:cl:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
You can now customize non-secure crates using packaging wrap, by tagging them and changing their appearance to a list of common crates. The tag works as a labeler label, and is also displayed in the overwatch supply drop alert.
Explain why it's good for the game
If anything, it's that these Squad crates are just sitting there unused. I don't know if this feature will be used much by live Reqs.
Changelog
🆑
add: You can now use package wrap to change standard crates visuals.
add: You can now label crate with package wrap, which will also be shown during overwatch supply drop alert.
mapadd: Added more packaging wrap to Requisitions.
/:cl: