/tg/ Status Effects Prelude A - Updated Trait Backend #4869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zonespace27
requested changes
Nov 7, 2023
| @@ -29,20 +29,6 @@ | |||
| if(!C.handcuffed) | |||
| place_handcuffs(C, user) | |||
|
|
|||
| /obj/item/handcuffs/obj/structure/MouseDrop(mob/living/carbon/human/H) | |||
There was a problem hiding this comment.
It is, that's why i'm getting rid of it on the spot
Zonespace27
approved these changes
Nov 8, 2023
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 13, 2023
# About the pull request AKA "Why are my leadership action buttons missing?" I was a bit too confident in #4869 copying over /tg/ backend and didn't question that Segrain's awesome CM-brewed traitbound elements bits were missing from their code. Oops. <!-- Remove this text and explain what the purpose of your PR is. Mention if you have tested your changes. If you changed a map, make sure you used the mapmerge tool. If this is an Issue Correction, you can type "Fixes Issue #169420" to link the PR to the corresponding Issue number #169420. Remember: something that is self-evident to you might not be to others. Explain your rationale fully, even if you feel it goes without saying. --> # Explain why it's good for the game Restores functionality for eg. silenced guns and leadership action buttons # Testing Photographs and Procedure Tested the actions are back # Changelog :cl: fix: Fixed an issue in traits backend update causing among others leadership action buttons to be missing. /:cl:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
Content from #4828 broken down in an individual PR
This does only a few things:
Testing Photographs and Procedure
Tested trait backend as part of main PR