Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should fix pumpkins, PUMPKINS EVERYWHERE #4881

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

fira
Copy link
Member

@fira fira commented Nov 8, 2023

About the pull request

Commit from cmss13-devs/cmss13-pve@0aa95b1

Turns out i'm a monkey and didn't think about This One Small Thing when refactoring, so the decorator keeps applying even without being active. Neat huh.

Explain why it's good for the game

Pumpkins overstepping their bounds. It's not much of a holiday if it's on all the time...

Changelog

🆑 MorrowWolf
fix: Fixed Pumpkins appearing past season.
/:cl:

@github-actions github-actions bot added the Fix Fix one bug, make ten more label Nov 8, 2023
@fira fira added the Testmerge Candidate we'll test this while you're asleep and the server has 10 players label Nov 8, 2023
Copy link
Contributor

@Drulikar Drulikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A new way to blame Morrow for changes, cherry picked commits :D

Anyways, this code looks fine. Other way would be to have the logic determining quantity of pumpkins when it gets -1 to do nothing, but this is more performant.

@BeagleGaming1 BeagleGaming1 added this pull request to the merge queue Nov 9, 2023
Merged via the queue into cmss13-devs:master with commit 653208a Nov 9, 2023
28 checks passed
cm13-github added a commit that referenced this pull request Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Fix one bug, make ten more Testmerge Candidate we'll test this while you're asleep and the server has 10 players
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants