Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close-Doors-When-Lockdown-Dropship #4883

Closed
wants to merge 1 commit into from
Closed

Close-Doors-When-Lockdown-Dropship #4883

wants to merge 1 commit into from

Conversation

hislittlecuzingames
Copy link
Contributor

@hislittlecuzingames hislittlecuzingames commented Nov 9, 2023

Closes Doors when you click "lockdown" on dropships before it locks the doors.

About the pull request

it closes the doors when you click lockdown before it locks the doors in the dropship on the airlock door level.

Explain why it's good for the game

when you lockdown a dropship, you intend for the doors to be closed then locked.
Before this change, doors may be locked open.

Testing Photographs and Procedure

Screenshots & Videos I opened a door, then went to control panel and clicked "lockdown" and saw it closed the doors immediately, and locked them where as before the change, doors may remain open.

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
qol: made doors close when you locked down dropships.
/:cl:

Closes Doors when you click "lockdown" on dropships before it locks the doors.
@github-actions github-actions bot added the Feature Feature coder badge label Nov 9, 2023
Copy link
Contributor

@BroseidonMOO BroseidonMOO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR fails to actually validate the door closed successfully.

@Diegoflores31
Copy link
Contributor

Diegoflores31 commented Nov 9, 2023

i dont think this is the file you should be touching . instead you should check the "lockdown" button itself . and make it uses close(forced = true) and maybe a check so you make sure the door will close

@hislittlecuzingames
Copy link
Contributor Author

hislittlecuzingames commented Nov 10, 2023

username: "Ihatethisengine2" suggested the following code snippet.
I didn't have time and just want to make sure I don't lose it:

/datum/shuttle/proc/force_close_launch(obj/structure/machinery/door/airlock/AL) // whatever. SLEEPS
    AL.safe = FALSE
    AL.unlock()
    AL.close()
    AL.lock()
    AL.safe = TRUE

@realforest2001 realforest2001 marked this pull request as draft November 14, 2023 05:56
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Nov 22, 2023
@github-actions github-actions bot closed this Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature coder badge Stale beg a maintainer to review your PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants