Refactor of ammo and it's children file to clean a bit BE code. #4886
Conversation
value in their parent object.
and remove a line that was already set in is parent object
more weapon to do BE
|
noticed that damage isn't set by define value ... not sure what to do with this but i could refactor this here if needed... |
|
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
|
Lets say at some point in the future we want to allow BE with other types of ammo. The user feedback and applied effects of these procs don't fit all |
yea i am probably going to let this PR auto-close and do something else around those file their is lot's to do on them.... |
|
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
|
not a real point to this PR closing it down |
About the pull request
Make it so that all child of ammo can use BE code instead of just bullet child.
Explain why it's good for the game
Testing Photographs and Procedure
Screenshots & Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>tags.Changelog
🆑
refactor: moved the two proc that handled BE to ammo object instead of bullet object allowing more gun to BE in the future.
refactor: removed some instance where variable where change for the value they already had.
/:cl: