Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing delay on climbing objects #4892

Closed
wants to merge 1 commit into from

Conversation

fira
Copy link
Member

@fira fira commented Nov 10, 2023

About the pull request

When you climb a structure such as railings or platform, the movement delay is not currently applied.
This means that while you're waiting for the climbing windup, the movement comes off cooldown, you climb, and move immediately a second time walking.

More than concerns about balance or consistency, i'm opening this PR because it's janky: it just feels really weird especially given that for a movement that is some distance away, BYOND will NOT apply the movement glide effrect and instead "teleport" you. This would be fine for Req Railings you jump over, but eg. lifeboat pumps platforms you constantly walk on/off simply by moving around.

Changelog

🆑
fix: Climbing rails and platforms now respects movement delay, preventing from "teleporting" 2 tiles at once.
/:cl:

@github-actions github-actions bot added the Fix Fix one bug, make ten more label Nov 10, 2023
@fira fira marked this pull request as draft November 11, 2023 01:30
@fira
Copy link
Member Author

fira commented Nov 11, 2023

this should probably use next_move instead but i'm a bit stupid, will advise

@fira
Copy link
Member Author

fira commented Nov 16, 2023

Yeah no next_move is for actions, this is correct

@fira fira marked this pull request as ready for review November 16, 2023 17:24
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Nov 24, 2023
@github-actions github-actions bot closed this Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Fix one bug, make ten more Stale beg a maintainer to review your PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant