-
Notifications
You must be signed in to change notification settings - Fork 565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactors a few vars on /mob/living/carbon/xenomorph #4899
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Birdtalon
commented
Nov 11, 2023
Comment on lines
-341
to
-343
// Defender vars | ||
var/used_headbutt = 0 | ||
var/used_fortify = 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are completely unused.
Comment on lines
-348
to
-355
//Carrier vars | ||
var/threw_a_hugger = 0 | ||
var/huggers_cur = 0 | ||
var/eggs_cur = 0 | ||
var/huggers_max = 0 | ||
var/eggs_max = 0 | ||
var/laid_egg = 0 | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved to the carrier subclass.
fira
approved these changes
Nov 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
wound_icon_carrier
&backpack_icon_carrier
towound_icon_holder
andbackpack_icon_holder
respectively. We have a caste called Carrier & disabiguation good.var/steelcrest
on all xenos with a check formutation_type == DEFENDER_STEELCREST
in defender code./mob/verb/debug_xeno_mind()
No gameplay impact.
Explain why it's good for the game
Testing Photographs and Procedure
Screenshots & Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>
tags.Changelog
🆑
code: Starts refactoring some vars on xenomorph class
/:cl: