Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactors a few vars on /mob/living/carbon/xenomorph #4899

Merged
merged 6 commits into from
Nov 13, 2023

Conversation

Birdtalon
Copy link
Contributor

@Birdtalon Birdtalon commented Nov 11, 2023

About the pull request

  • Renames wound_icon_carrier & backpack_icon_carrier to wound_icon_holder and backpack_icon_holder respectively. We have a caste called Carrier & disabiguation good.
  • Deletes unused defender related vars
  • Replaces var/steelcrest on all xenos with a check for mutation_type == DEFENDER_STEELCREST in defender code.
  • Corrects small style inconsistency in /mob/verb/debug_xeno_mind()

No gameplay impact.

Explain why it's good for the game

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
code: Starts refactoring some vars on xenomorph class
/:cl:

@github-actions github-actions bot added the Code Improvement Make the code longer label Nov 11, 2023
Comment on lines -341 to -343
// Defender vars
var/used_headbutt = 0
var/used_fortify = 0
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are completely unused.

Comment on lines -348 to -355
//Carrier vars
var/threw_a_hugger = 0
var/huggers_cur = 0
var/eggs_cur = 0
var/huggers_max = 0
var/eggs_max = 0
var/laid_egg = 0

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved to the carrier subclass.

@harryob harryob added this pull request to the merge queue Nov 13, 2023
Merged via the queue into cmss13-devs:master with commit 45d5fb6 Nov 13, 2023
26 checks passed
cm13-github added a commit that referenced this pull request Nov 13, 2023
@Birdtalon Birdtalon deleted the xeno_vars branch December 21, 2023 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Improvement Make the code longer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants