Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warrior: replace single letter vars & remove redundant code #4921

Merged
merged 3 commits into from
Nov 25, 2023

Conversation

Birdtalon
Copy link
Contributor

@Birdtalon Birdtalon commented Nov 13, 2023

About the pull request

  • Replaces single letter vars in warrior code.
  • Removes redundant abilities.
  • Some formatting improvements, single line return etc

Explain why it's good for the game

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
code: Replaces single letter vars removes redundant abilitiesin warrior code.
/:cl:

@github-actions github-actions bot added the Feature Feature coder badge label Nov 13, 2023
@@ -1,17 +1,3 @@
// toggle agility
/datum/action/xeno_action/onclick/toggle_agility
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you are going to remove agility you should remove it completely

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the time I did this the plan was to remove var/agility from xenomorph class in refactor of xenomorph.dm as I was unsure if it was modified elsewhere as it is also referenced in prae code. But having looked deeper it looks like I can just remove all checks for agility in Warrior code.

Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Nov 25, 2023
@harryob harryob added this pull request to the merge queue Nov 25, 2023
Merged via the queue into cmss13-devs:master with commit 2099a52 Nov 25, 2023
26 checks passed
cm13-github added a commit that referenced this pull request Nov 25, 2023
@Birdtalon Birdtalon deleted the warrior branch December 21, 2023 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature coder badge Stale beg a maintainer to review your PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants