Sorokyne Corporate Liaison #4942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Feature
|
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
fira
approved these changes
Dec 1, 2023
realforest2001
approved these changes
Dec 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
adds a corporate liaison survivor to sorokyne, along with a subtype of the liaison's winter coat that can holster guns and a few other utility items/weapons. it cannot hold any rifle magazines or similarly sized items in its pockets though because there should be a tradeoff for how cool it looks.
also fixed a very small typo in the political prisoner's name and assignment.
Explain why it's good for the game
more diversity in survivor types is good, map didn't have a corporate survivor, a really cool sprite sees more use, fits with the map's lore, etc.
the subtype of the liaison's winter coat is only available on this map at the moment, and it's a downgrade from the survivor snowsuits/soviet snowcoats that already spawn on sorokyne, so it's a fine tradeoff for it looking cool i think. if needed i can always just make it a regular liaison's winter coat.
typos are bad!!!
Testing Photographs and Procedure
Screenshots & Videos
It's a cold day in Hell, suit.
Changelog
🆑IowaPotatoFarmer
add: Added a Corporate Liaison survivor to Sorokyne.
add: Added a modified version of the liaison's winter coat that allows it to holster guns and a few other things. Only available to the Sorokyne Strata Corporate Liaison for now.
spellcheck: Fixed a typo in the Sorokyne Strata Political Prisoner's ID tag.
/:cl: