Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hivecores perform multiple spawns at once #4953

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

Drulikar
Copy link
Contributor

@Drulikar Drulikar commented Nov 17, 2023

About the pull request

This PR simply makes it so hive cores try to dequeue as many larva as they have stored_larva each larva spawn delay rather than a single larva.

Explain why it's good for the game

Fixes #4945

Testing Photographs and Procedure

  1. Spawn as queen
  2. Create core
  3. Ensure hive has 2 stored_larva
  4. Ghost (Have two admin clients at this point observing)
  5. Ensure both clients have xeno preference set and then lose larva protections (assuming admin)
  6. Both will spawn at once
  7. Try again with 1 stored_larva
  8. One will spawn and other has queue message updated

Changelog

🆑 Drathek
fix: Tweaked larva queue spawning: Now spawns as many larva as possible each cycle rather than one.
/:cl:

@github-actions github-actions bot added the Fix Fix one bug, make ten more label Nov 17, 2023
@Drulikar Drulikar changed the title Perform multiple spawns at once Hivecores perform multiple spawns at once Nov 17, 2023
Copy link
Member

@fira fira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@fira fira added this pull request to the merge queue Nov 22, 2023
Merged via the queue into cmss13-devs:master with commit eeee374 Nov 22, 2023
28 checks passed
cm13-github added a commit that referenced this pull request Nov 22, 2023
@Drulikar Drulikar deleted the Faster_Larva_Dequeue branch November 22, 2023 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Fix one bug, make ten more
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Join as Larva Delay
2 participants