Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes a couple of istype(src) & unused proc #4955

Merged
merged 3 commits into from
Nov 22, 2023

Conversation

Birdtalon
Copy link
Contributor

@Birdtalon Birdtalon commented Nov 18, 2023

About the pull request

Removes a couple if istype(src) I noticed.

  • GetJobRealName() removed this is never called
  • GetJobName() moved into the scope of /obj/item/card/id instead of /obj This is only ever called in that object.
  • Moves make_dizzy() processing into /mob/living/carbon/human and removes istype(src) on /mob

Explain why it's good for the game

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
code: Removes some istype(src)
/:cl:

@github-actions github-actions bot added the Code Improvement Make the code longer label Nov 18, 2023
@fira fira added this pull request to the merge queue Nov 22, 2023
Merged via the queue into cmss13-devs:master with commit e7d3ce0 Nov 22, 2023
28 checks passed
cm13-github added a commit that referenced this pull request Nov 22, 2023
@Birdtalon Birdtalon deleted the heresy branch December 21, 2023 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Improvement Make the code longer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants