Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Survivor Job Additions + Some Minor Fixes #4956

Merged
merged 6 commits into from
Dec 16, 2023

Conversation

BadAtThisGame302
Copy link
Contributor

@BadAtThisGame302 BadAtThisGame302 commented Nov 18, 2023

About the pull request

The purpose of this Pull Request is adding more survivor jobs like Flight Control Operator, most colonies have a small office in their space port or near the administration area that has a bubble for an ATC Officer or Operator, so as Cooliecan said on https://forum.cm-ss13.com/t/spitballing-ideas-for-new-survivor-jobs-on-all-colonies-maps/5136/2 which I agree with, could be fun to LARP as an ATC since an area for that character does exist.

Explain why it's good for the game

Increases diversity for survivor jobs, could add more RP opportunities, plus like the Soro CL PR, LV has no special Liaison job like Solaris so I thought why not, it has a large corpo dome it deserves a unique Liaison IMO. Now, about the Flight Control Operator, the name speaks for itself, most spaceports have a flight control bubble which are manned by Flight Control Operators/Officers, I gave him the trucker skills, though I thought about changing it to engineer stats. Didn't put him in any category he is like civilians a random for now (Don't think he fits in Engineer or Corporate category, or maybe he does?)

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
add: Added a LV-624 Corporate Liaison Survivor.
add: Added a Flight Control Operator Survivor to Solaris Ridge (for now, might be added to more maps soon!).
qol: made survivor.dm easier to use by moving the basic security surv with the engineer/scientist/doctor which it wierdly enough it wasn't with.
balance: rebalanced CL a lockable satchel.
fix: fixed the survivor.dm comments falsely saying that some surv types are not used anywhere when they are.
spellcheck: fixed the LV-624 announcement text, made it roll off the tongue easier.
code: changed CL and ICC survs shoes from centcom? To laceup.
/:cl:

@github-actions github-actions bot added Feature Feature coder badge Quality of Life Make the game harder to play Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Fix Fix one bug, make ten more Grammar and Formatting Fixes the codebase's tpyos and grammatical's errors Code Improvement Make the code longer labels Nov 18, 2023
@cm13-github
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@cm13-github cm13-github added the Merge Conflict PR can't be merged because it touched too much code label Nov 25, 2023
@cm13-github
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@cm13-github cm13-github removed the Merge Conflict PR can't be merged because it touched too much code label Nov 26, 2023
Copy link
Contributor

github-actions bot commented Dec 3, 2023

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Dec 3, 2023
@cm13-github cm13-github added the Merge Conflict PR can't be merged because it touched too much code label Dec 6, 2023
@cm13-github
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@cm13-github cm13-github removed the Merge Conflict PR can't be merged because it touched too much code label Dec 6, 2023
@cm13-github
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions github-actions bot removed the Stale beg a maintainer to review your PR label Dec 7, 2023
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Dec 15, 2023
@Zonespace27 Zonespace27 added Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. and removed Stale beg a maintainer to review your PR labels Dec 16, 2023
@Zonespace27 Zonespace27 added this pull request to the merge queue Dec 16, 2023
Merged via the queue into cmss13-devs:master with commit 01174dd Dec 16, 2023
26 checks passed
cm13-github added a commit that referenced this pull request Dec 16, 2023
@BadAtThisGame302 BadAtThisGame302 deleted the survivor_changes branch December 16, 2023 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Code Improvement Make the code longer Feature Feature coder badge Fix Fix one bug, make ten more Grammar and Formatting Fixes the codebase's tpyos and grammatical's errors Quality of Life Make the game harder to play
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants