Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More accurate directions for trackers and messages #4961

Merged
merged 1 commit into from
Nov 24, 2023

Conversation

Doubleumc
Copy link
Contributor

@Doubleumc Doubleumc commented Nov 19, 2023

About the pull request

image

Swaps out get_dir() for Get_Compass_Dir() in multiple places. The criteria for the swap was:

  • subject can be more than one tile away (otherwise results identical to get_dir())
  • is fed into a pointer or a warning message
  • not used outside the pointer or message

This should not effect any actual game logic, only informative indicators.

Explain why it's good for the game

Directional indicators should mean what people generally understand them to be. "Northeast" should be more accurate than "east and one tile north".

Testing Photographs and Procedure

Screenshots & Videos

Before:
image

After:
image

Changelog

🆑
qol: directions in trackers and messages are more accurate
/:cl:

@Doubleumc Doubleumc requested a review from fira as a code owner November 19, 2023 06:35
@github-actions github-actions bot added the Quality of Life Make the game harder to play label Nov 19, 2023
@harryob harryob added this pull request to the merge queue Nov 24, 2023
Merged via the queue into cmss13-devs:master with commit 622a284 Nov 24, 2023
28 checks passed
cm13-github added a commit that referenced this pull request Nov 24, 2023
@Doubleumc Doubleumc deleted the tracker-accuracy branch November 25, 2023 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Quality of Life Make the game harder to play
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants