Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix null limb owner runtime. #4973

Closed
wants to merge 1 commit into from

Conversation

Zonespace27
Copy link
Contributor

@Zonespace27 Zonespace27 commented Nov 20, 2023

About the pull request

image

The rest of the code seems to always check for owner, so I suppose having an owner isn't guaranteed?

@Zonespace27 Zonespace27 added the Fix Fix one bug, make ten more label Nov 20, 2023
@fira
Copy link
Member

fira commented Nov 20, 2023

owner should always be set i think? i had a similar problem not long ago further down in IIRC get_limb_icon_key where species was unexpectedly null. the fix was #4805 - the limbs were deleted and not actually cleared

just like #4966 i think it usually means the whole damned thing is deleted and improperly used to begin with

Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Nov 28, 2023
@github-actions github-actions bot closed this Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Fix one bug, make ten more Stale beg a maintainer to review your PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants