Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes the XM43E1 and the M42C #4974

Merged
merged 4 commits into from
Nov 24, 2023
Merged

Conversation

Releasethesea
Copy link
Contributor

@Releasethesea Releasethesea commented Nov 20, 2023

About the pull request

they had the wrong barrel overlay giving them the normal marine spec sniper barrel, the XM43E1 was only named that in one location which made it spawn improperly, this has been fixxed and i went and renamed everything relating to its old name which was the XM42B

Explain why it's good for the game

Visual bugs arent fun, fixing them is very important, this fixes what was broken, so yippie

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

https://imgur.com/EV52Q7S
all three snipers, with correct barrels

https://imgur.com/XiH0fSL
M42C rifle with correct barrel, in hand

https://imgur.com/piifH2q
XM43E1 with correct barrel in hand

https://imgur.com/Y5kGftc
https://imgur.com/5IJsoS9
https://imgur.com/ZHAglSC
all items relating to the XM43E1 being correctly named and functioning like normal

sorry i didnt feel like screenshotting every single helmet and head item that could fit the pipe

Changelog

🆑

fix: fixes the XM43E1s name (previously named XM42B) and sprite, fixes the M42C and XM43E1s barrel, correctly names several items relating to the XM43E1

/:cl:

@github-actions github-actions bot added Sprites Remove the soul from the game. Fix Fix one bug, make ten more labels Nov 20, 2023
@Releasethesea
Copy link
Contributor Author

ah i made a mistake, i forgot to correct the onmob sprite icons names, ill fix it real fast!

@Releasethesea
Copy link
Contributor Author

for some reason this didnt have a suit slot or back sprite, ive made placeholders using the M42C sprites because they look similar

Copy link
Contributor

@nauticall nauticall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep

@nauticall nauticall added the Sprites Approved confirmed no stray pixels label Nov 23, 2023
@harryob harryob added this pull request to the merge queue Nov 24, 2023
Merged via the queue into cmss13-devs:master with commit 4047c47 Nov 24, 2023
26 checks passed
cm13-github added a commit that referenced this pull request Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Fix one bug, make ten more Sprites Approved confirmed no stray pixels Sprites Remove the soul from the game.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants