Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Legacy food sprite redux revive #4975

Merged
merged 5 commits into from
Dec 4, 2023

Conversation

ItsVyzo
Copy link
Contributor

@ItsVyzo ItsVyzo commented Nov 20, 2023

About the pull request

revives #3008

Explain why it's good for the game

soul

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑 triiodine
imageadd: resprites a whole bunch of legacy food sprites including but not limited: all burgers, all soups, all salads, etc
/🆑

@github-actions github-actions bot added Sprites Remove the soul from the game. Feature Feature coder badge labels Nov 20, 2023
@ItsVyzo ItsVyzo marked this pull request as ready for review November 20, 2023 02:53
@ItsVyzo ItsVyzo added Roadmap "I think you're holding it upside down" and removed Roadmap "I think you're holding it upside down" labels Nov 20, 2023
@BeagleGaming1
Copy link
Contributor

You may have reverted some other sprite changes in this PR, please double check that you did not edit what you did not mean to edit

@ItsVyzo
Copy link
Contributor Author

ItsVyzo commented Nov 20, 2023

You may have reverted some other sprite changes in this PR, please double check that you did not edit what you did not mean to edit

Oh god, will have a look

@ItsVyzo ItsVyzo marked this pull request as draft November 20, 2023 02:58
@ItsVyzo ItsVyzo marked this pull request as ready for review November 20, 2023 03:26
@ItsVyzo ItsVyzo added the Roadmap "I think you're holding it upside down" label Nov 20, 2023
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Nov 28, 2023
Copy link
Contributor

@nauticall nauticall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mmhmm! lgtm

@nauticall nauticall added Sprites Approved confirmed no stray pixels and removed Stale beg a maintainer to review your PR labels Dec 3, 2023
@Drulikar Drulikar added this pull request to the merge queue Dec 4, 2023
Merged via the queue into cmss13-devs:master with commit 9a8dbb6 Dec 4, 2023
27 checks passed
@ItsVyzo ItsVyzo deleted the legacyfoodrevive branch December 6, 2023 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature coder badge Roadmap "I think you're holding it upside down" Sprites Approved confirmed no stray pixels Sprites Remove the soul from the game.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants