Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The return of the extra van sprites #4993

Closed
wants to merge 7 commits into from
Closed

The return of the extra van sprites #4993

wants to merge 7 commits into from

Conversation

silencer-pl
Copy link
Contributor

@silencer-pl silencer-pl commented Nov 21, 2023

About the pull request

This reopens #1789 , fixes it so it works with current CM code (interior names are moved to a datum now which had to be adjusted) and makes the red van a bit darker per feedback the source.

I got this working by request on intend to use it in our downstream, but there is zero reason this should not be upstream I think since it seemed to already clear pretty much everything but the sprtier check.

Explain why it's good for the game

Variety in your random vehicles. Blow that checkpoint with a van in style, or something. Useful for events or occasional admin spawn of various shape and form anyway.

Also one less modification I have to keep track downstream of you guys.

Testing Photographs and Procedure

Changelog

🆑Legnord,silencer_pl
add: Adds several new colony trucks, vans, a crane and three military van variants
imageadd: adds sprites for cars and wheels for the above
/:cl:

@github-actions github-actions bot added Sprites Remove the soul from the game. Mapping did you remember to save in tgm format? Feature Feature coder badge labels Nov 21, 2023
@silencer-pl

This comment was marked as resolved.

ERROR: Last item in a long list should still have a comma.

Errors found, please fix them and try again.

Whatever you say, Linter.
,
ONE MORE COMA XD
Also, the lack of an icon for an item state that does not exist in game. Thank you, code checker.
Copy link
Member

@fira fira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could use a bit less V and more vehicle, and a bit less I and more vehicle_type
but code looks cool

@silencer-pl
Copy link
Contributor Author

could use a bit less V and more vehicle, and a bit less I and more vehicle_type but code looks cool

Honestly did not look at the code at all, I saw it got approved by stan in the previous MR and that was good enough for me, though I do think it also complained about using var/ in front of some of the lists needlessly too and as you can see in the comits, the Linter was mad at some of the syntax (nevermind the extra dm file I left there for some reason) but yeah in the end it worked with no issue.

@Nanu308 Nanu308 added the Mapping Approved adds 500 new dict keys label Nov 22, 2023
Copy link
Member

@Nanu308 Nanu308 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mapping seems fine

Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Nov 30, 2023
@github-actions github-actions bot closed this Dec 7, 2023
@silencer-pl
Copy link
Contributor Author

A shame

@silencer-pl silencer-pl deleted the vehupload branch February 4, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature coder badge Mapping Approved adds 500 new dict keys Mapping did you remember to save in tgm format? Sprites Remove the soul from the game. Stale beg a maintainer to review your PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants