Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Pizza to Requisitions #4998

Merged
merged 3 commits into from
Nov 24, 2023
Merged

Conversation

HeresKozmos
Copy link
Contributor

@HeresKozmos HeresKozmos commented Nov 22, 2023

About the pull request

Adds a box of pizza and a replica of PIZZA TIME to Requisitions.

Explain why it's good for the game

I miss the days of Requisitions having pizza... I also miss PIZZA TIME...

Testing Photographs and Procedure

image

Changelog

🆑
add: Added pizza and pizza cutter to Req
del: Deleted a random kepler crisps bag
/:cl:

@github-actions github-actions bot added Mapping did you remember to save in tgm format? Feature Feature coder badge Removal snap labels Nov 22, 2023
Copy link
Member

@Nanu308 Nanu308 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the Pizza cutter you see is actually quite strong, quite so, so if you're adding it to the Almayer make a subtype of it that's weaker or VV the Pizza cutter to be more akin to a knife.

Other than that, the mapping seems fine.

@Nanu308 Nanu308 marked this pull request as draft November 23, 2023 02:21
@HeresKozmos
Copy link
Contributor Author

So the Pizza cutter you see is actually quite strong, quite so, so if you're adding it to the Almayer make a subtype of it that's weaker or VV the Pizza cutter to be more akin to a knife.

Other than that, the mapping seems fine.

I'm going to attempt to make it have only 20 melee damage (I believe bayonets are 25) and I will name it "Replica PIZZA TIME" and change its description to reflect it.

@HeresKozmos
Copy link
Contributor Author

HeresKozmos commented Nov 23, 2023

Tested it, it deals 20 melee damage as intended.

Hit the mob once.
image

The description;
image

@HeresKozmos HeresKozmos marked this pull request as ready for review November 23, 2023 20:55
@Nanu308 Nanu308 added the Mapping Approved adds 500 new dict keys label Nov 24, 2023
Copy link
Member

@Nanu308 Nanu308 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Nanu308 Nanu308 added this pull request to the merge queue Nov 24, 2023
Merged via the queue into cmss13-devs:master with commit 8e711c0 Nov 24, 2023
26 checks passed
cm13-github added a commit that referenced this pull request Nov 24, 2023
github-merge-queue bot pushed a commit that referenced this pull request Nov 25, 2023
# About the pull request
I forgot how comically big this is with the in-hand sprite and it looks
really stupid so removing it. Can be re-added when someone makes a
proper sprite for it.

Partly revert of #4998
# Explain why it's good for the game
I forgot how comically big this is with the in-hand sprite and it looks
really stupid so removing it. Can be re-added when someone makes a
proper sprite for it.

# Testing Photographs and Procedure
<details>
<summary>Screenshots & Videos</summary>

Put screenshots and videos here with an empty line between the
screenshots and the `<details>` tags.

</details>


# Changelog
:cl:
del: Removed the Pizza Cutter.
/:cl:
@HeresKozmos HeresKozmos deleted the RequisitionsBuff branch November 27, 2023 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature coder badge Mapping Approved adds 500 new dict keys Mapping did you remember to save in tgm format? Removal snap
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants