Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Système d'énergie de commandement - 1 #5011

Closed
wants to merge 57 commits into from

Conversation

LC4492
Copy link
Contributor

@LC4492 LC4492 commented Nov 22, 2023

About the pull request

This PR is focused on setting the CIC Power Substation on where the Synthetic Closet originally is, and move that same closet to where the station once was, improving mobility by reducing the amount of time the synthetics spend on walking to their closet and also improving protection to the power station by placing it in the secure hall of CIC.

Explain why it's good for the game

If the explanation above is good enough, then I suppose its good for the game.

Testing Photographs and Procedure

image
New power substation
image
New synthetic closet

Changelog

🆑
maptweak: Sets the CIC power station to where the synthetic closet is currently located, and moves the synthetic closet to where the power station is currently located. Improves APC positioning, adds more lights to specific areas where there should be more, fixes stuff that were blocking the view of signs and making them ugly.
/:cl:

LC4492 added 30 commits April 1, 2023 14:25
@github-actions github-actions bot added the Mapping did you remember to save in tgm format? label Nov 22, 2023
@fira
Copy link
Member

fira commented Nov 24, 2023

Are the changes in Cryo intentional?

@LC4492
Copy link
Contributor Author

LC4492 commented Nov 24, 2023

Are the changes in Cryo intentional?

Yes. When I made the substation side, I needed to change the position of some airlocks for to everything fit sweetly, that's when I stopped and needed to do some little changes to the cryo side. I added some extra windows and re-positioned the chambers in the process, thought it would make it look better.

Copy link
Member

@Nanu308 Nanu308 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brig has this because people were memeing and causing issues with the APC's, i do not think it should be expanded to other parts of the ship. I think we should strive to keep it like in Alien Isolation where APC's are in almost every single case located in the rooms themselves and not bunched up together.

Moving the Synth closet is fine, and moving the SMES storage in is also fine, but the room that used to house the synth spot looks really boxy now so I'd do some tweaks to make it look better.

There are some good map fixes tho besides this. 👍

@Nanu308 Nanu308 marked this pull request as draft November 29, 2023 14:22
@cm13-github cm13-github added the Merge Conflict PR can't be merged because it touched too much code label Nov 29, 2023
@cm13-github
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Copy link
Contributor

github-actions bot commented Dec 7, 2023

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Dec 7, 2023
@LC4492 LC4492 closed this Dec 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mapping did you remember to save in tgm format? Merge Conflict PR can't be merged because it touched too much code Stale beg a maintainer to review your PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants