Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lockdown actually closes doors on DS #5015

Merged
merged 1 commit into from
Nov 24, 2023

Conversation

ihatethisengine
Copy link
Contributor

About the pull request

Lockdown actually closes doors on DS.

Explain why it's good for the game

It used to be the case before the gui rework. I think. Anyway DP should be able to control doors, hunting for the moment when all doors are closed to lock them is extremely not fun.

Testing Photographs and Procedure

:)

Changelog

🆑 ihatethisengine
add: Locking down dropship's doors closes them before locking.
/:cl:

@github-actions github-actions bot added UI deletes nanoui/html Feature Feature coder badge labels Nov 23, 2023
@harryob harryob added this pull request to the merge queue Nov 24, 2023
Merged via the queue into cmss13-devs:master with commit e5e18a5 Nov 24, 2023
28 checks passed
cm13-github added a commit that referenced this pull request Nov 24, 2023
github-merge-queue bot pushed a commit that referenced this pull request Feb 27, 2024
# About the pull request
<!-- Remove this text and explain what the purpose of your PR is.

Mention if you have tested your changes. If you changed a map, make sure
you used the mapmerge tool.
If this is an Issue Correction, you can type "Fixes Issue #169420" to
link the PR to the corresponding Issue number #169420.

Remember: something that is self-evident to you might not be to others.
Explain your rationale fully, even if you feel it goes without saying.
-->
#5015 this PR allowed a lot
better control of the doors for POs, but as it turned out Queen cannot
disable door control from the outside anymore. So it led to dropships to
be basically unenterable if PO controls the cockpit. Now pried open
hatch cannot be remotely locked anymore. Engineer can fix the door by
multitooling.

# Explain why it's good for the game
Xenos can assault dropships again.

# Testing Photographs and Procedure

<details>
<summary>Screenshots & Videos</summary>


![2024-02-25_21-02-58](https://github.com/cmss13-devs/cmss13/assets/115417687/5f38c206-e26c-43fe-b247-cb2dd407797a)

</details>


# Changelog
:cl: ihatethisengine
balance: Pried open dropship hatches cannot be remotely locked anymore
/:cl:

---------

Co-authored-by: Drathek <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature coder badge UI deletes nanoui/html
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants